Bug #688

shore tiles

Added by planetmaker almost 10 years ago. Updated almost 10 years ago.

Status:ClosedStart date:2009-12-17
Priority:NormalDue date:
Assignee:planetmaker% Done:

100%

Category:Extras
Target version:0.2.1

Description

In conjunction with certain newgrfs, the current OpenGFX shores don't work well. There's a 10-tile and a 16-tile variant available. According to frosch and the TTDP newgrf wiki, only the 10-tile variant is safe for use in newgrfs: http://wiki.ttdpatch.net/tiki-index.php?page=Action5

coasts_extra_r281.diff Magnifier (5.98 KB) planetmaker, 2009-12-18 13:03

basegrf_check.diff Magnifier - grfID check (1004 Bytes) planetmaker, 2009-12-18 19:02

Associated revisions

Revision 283:9c6e43375406
Added by planetmaker almost 10 years ago

Fix: Allow newgrfs to overwrite coastal ground sprites (closes #688)
Change: The newgrf ID of the extra newgrf changes to FF "OT" 01

Revision 283:9c6e43375406
Added by planetmaker almost 10 years ago

Fix: Allow newgrfs to overwrite coastal ground sprites (closes #688)
Change: The newgrf ID of the extra newgrf changes to FF "OT" 01

History

#1 Updated by planetmaker almost 10 years ago

Mind the possible outcome:

#2 Updated by planetmaker almost 10 years ago

Indeed, the results look as in the image. I wonder why the additional shore sprites aren't used, even if defined in the extra (new)grf.

#3 Updated by Ammler almost 10 years ago

It seems like openttd has troubles to detect the 10 sprites variant, how does that happen?

dbg: [grf] [opengfx/ogfxe_extra.grf:1854] GRFComment: Missing shore tile graphics for the Temperate climate
dbg: [grf] [opengfx/ogfxe_extra.grf:1855] GraphicsNew: Shore graphics (type 0x0D) count must be at least 16. Only 10 were specified. Skipping.

#4 Updated by planetmaker almost 10 years ago

Further investigation revealed that the OpenTTDw grfID is queried - and we use a different one. The attached patch to OpenTTD trunk r18527 changes this by only looking for a GRFID starting with FF. See also FS #3385 http://bugs.openttd.org/task/3385

#5 Updated by Ammler almost 10 years ago

Does that mean, you have to suspend applying the patch until this fix goes to trunk/0.7?

#6 Updated by planetmaker almost 10 years ago

It means that the OpenGFX patch in the form as posted won't be commited unless
- we change also the GRFID
- or something along the lines / with a similar result of the OpenTTD patch I posted will hit trunk
- or someone shows me a solution totally different :-)

#7 Updated by planetmaker almost 10 years ago

  • Status changed from Confirmed to Closed
  • % Done changed from 0 to 100

Applied in changeset r283.

Also available in: Atom PDF