Feature #662

Rework trains

Added by planetmaker over 9 years ago. Updated over 8 years ago.

Status:ClosedStart date:2009-12-03
Priority:NormalDue date:
Assignee:planetmaker% Done:

100%

Category:Base
Target version:0.3.0

Description

check out the attached trains and replace possibly the existing trains.

Also unify and improve the alignment of trains.

Note: 28px is the widest which is displayed correctly in the depot view, if no 32px newgrf flag can be used.

newtrains.pcx - new trains (98.1 KB) planetmaker, 2009-12-03 19:48

temperatetrains.pcx (148 KB) planetmaker, 2009-12-03 23:56

temperatetrains_molace.png - reworked version by molace (43.8 KB) planetmaker, 2010-03-25 15:55

ArcticOpenGFX_danmack.png - arctic rail vehicles by DanMacK (37.8 KB) planetmaker, 2010-03-25 15:55

Harzhaven_Transport__22-08-2050.png (110 KB) planetmaker, 2010-04-21 23:01

Harzhaven_Transport__06-08-2051.png (108 KB) planetmaker, 2010-04-22 07:26

original.png - original alignment (806 KB) planetmaker, 2010-04-23 09:58

opengfx.png - opengfx alignment (1010 KB) planetmaker, 2010-04-23 10:01


Related issues

Related to OpenGFX - Bug #321: Monorails clipping tunnels Closed 2009-07-12
Blocked by OpenGFX - Bug #906: livery mismatch Millenium and PAX/Mail wagons Closed 2010-04-26

Associated revisions

Revision 264:f93aeb981f77
Added by planetmaker over 9 years ago

Change: Replace all monorail & maglev wagons by wagons of the correct size (Graphics by molace)
Doc: Document which maglev wagon sprite numbers correspond to which cargo and loading state (part of issue #662)

Revision 264:f93aeb981f77
Added by planetmaker over 9 years ago

Change: Replace all monorail & maglev wagons by wagons of the correct size (Graphics by molace)
Doc: Document which maglev wagon sprite numbers correspond to which cargo and loading state (part of issue #662)

Revision 271:e75bb4d421fc
Added by planetmaker over 9 years ago

Fix (r258): There's only one wagon type for toyland. Use the normal ones for all rail types. Also document wagons a bit better (part of issue #662)

Revision 271:e75bb4d421fc
Added by planetmaker over 9 years ago

Fix (r258): There's only one wagon type for toyland. Use the normal ones for all rail types. Also document wagons a bit better (part of issue #662)

Revision 384:e6439f1da23c
Added by planetmaker about 9 years ago

Change [#662]: New graphics for Powernaut steam engine (graphics by DanMacK)

Revision 384:e6439f1da23c
Added by planetmaker about 9 years ago

Change [#662]: New graphics for Powernaut steam engine (graphics by DanMacK)

Revision 388:e67108364813
Added by planetmaker about 9 years ago

Change [#662]: Apply the alignment template to all monorail and maglev wagons

Revision 388:e67108364813
Added by planetmaker about 9 years ago

Change [#662]: Apply the alignment template to all monorail and maglev wagons

Revision 389:8d8811bd1be9
Added by planetmaker about 9 years ago

Add [#662]: Template for 32px wagons, even though they glitch in depot view

Revision 389:8d8811bd1be9
Added by planetmaker about 9 years ago

Add [#662]: Template for 32px wagons, even though they glitch in depot view

Revision 390:6341dc4b53b6
Added by planetmaker about 9 years ago

Change [#662]: Move temperate rail wagons to their own pcx file
Change: Use the 32px template for the temperate rail wagons
Doc: Which sprite represents which wagon for temperate rail

Revision 390:6341dc4b53b6
Added by planetmaker about 9 years ago

Change [#662]: Move temperate rail wagons to their own pcx file
Change: Use the 32px template for the temperate rail wagons
Doc: Which sprite represents which wagon for temperate rail

Revision 391:93c3c122fa88
Added by planetmaker about 9 years ago

Change [#662]: Move arctic rail wagons to their own file
Change: Apply the 32px wagon template to arctic rail wagons
Doc: Document cargos, which sprites replace temperate sprites and which are unique

Revision 391:93c3c122fa88
Added by planetmaker about 9 years ago

Change [#662]: Move arctic rail wagons to their own file
Change: Apply the 32px wagon template to arctic rail wagons
Doc: Document cargos, which sprites replace temperate sprites and which are unique

Revision 392:97e1fbb4b753
Added by planetmaker about 9 years ago

Change [#662]: Move tropical rail wagons to their own file
Change: Use the 32px rail wagon template for tropical rail wagons
Doc: Document which sprite refer to which wagon and cargo

Revision 392:97e1fbb4b753
Added by planetmaker about 9 years ago

Change [#662]: Move tropical rail wagons to their own file
Change: Use the 32px rail wagon template for tropical rail wagons
Doc: Document which sprite refer to which wagon and cargo

Revision 415:4e136020d46b
Added by planetmaker about 9 years ago

Fix [#662]: Improve alignment of toyland maglev engine and wagons a bit
Fix [#662]: Improve alignment of Ploddyphut ChooChoo

Revision 415:4e136020d46b
Added by planetmaker about 9 years ago

Fix [#662]: Improve alignment of toyland maglev engine and wagons a bit
Fix [#662]: Improve alignment of Ploddyphut ChooChoo

Revision 416:b66b0c3cabbc
Added by planetmaker about 9 years ago

Fix [#662]: Fix the alignment of the Ploddyphut properly and don't just use random numbers which work elsewhere

Revision 416:b66b0c3cabbc
Added by planetmaker about 9 years ago

Fix [#662]: Fix the alignment of the Ploddyphut properly and don't just use random numbers which work elsewhere

Revision 417:5d50975fa3cf
Added by planetmaker about 9 years ago

Fix [#662]: Improve alignment of temperate wagons
Add: Alignment template for 9/8 train vehicles in 2cctrainset style

Revision 417:5d50975fa3cf
Added by planetmaker about 9 years ago

Fix [#662]: Improve alignment of temperate wagons
Add: Alignment template for 9/8 train vehicles in 2cctrainset style

Revision 418:e24c306b475c
Added by planetmaker about 9 years ago

Fix [#662]: Improve alignment of Dash diesel train by using the 9/8 length template
Change: Move sprites of Dash diesel train to their own file

Revision 418:e24c306b475c
Added by planetmaker about 9 years ago

Fix [#662]: Improve alignment of Dash diesel train by using the 9/8 length template
Change: Move sprites of Dash diesel train to their own file

Revision 419:12bcf837aa3d
Added by planetmaker about 9 years ago

Fix [#662]: Move Manley Morel sprites to its own file and use the 9/8 alignment template

Revision 419:12bcf837aa3d
Added by planetmaker about 9 years ago

Fix [#662]: Move Manley Morel sprites to its own file and use the 9/8 alignment template

Revision 420:b5cb3c727284
Added by planetmaker about 9 years ago

Add [#662]: Add alignment template for 8/8 lengths engine sprites
Fix [#662]: Alignment of SH125 using the 8/8 length template
Change [#662]: Move sprites of the SH125 to their own file

Revision 420:b5cb3c727284
Added by planetmaker about 9 years ago

Add [#662]: Add alignment template for 8/8 lengths engine sprites
Fix [#662]: Alignment of SH125 using the 8/8 length template
Change [#662]: Move sprites of the SH125 to their own file

Revision 421:d40e0fc1e78e
Added by planetmaker about 9 years ago

Change [#662]: Alignment of maglev wagons

Revision 421:d40e0fc1e78e
Added by planetmaker about 9 years ago

Change [#662]: Alignment of maglev wagons

Revision 422:042f57ca08fd
Added by planetmaker about 9 years ago

Change [#662]: Enlarge the height of the 8/8 graphics template by one pixel and use that
Change [#662]: Move AsiaStar to its own separate pcx file and use the 8/8 lengths alignment template

Revision 422:042f57ca08fd
Added by planetmaker about 9 years ago

Change [#662]: Enlarge the height of the 8/8 graphics template by one pixel and use that
Change [#662]: Move AsiaStar to its own separate pcx file and use the 8/8 lengths alignment template

Revision 423:6b9f69a4b644
Added by planetmaker about 9 years ago

Change [#662]: Unify alignment to a common base
Doc [#662]: Document how to derive alignment sets for differently sized sprite sets

Revision 423:6b9f69a4b644
Added by planetmaker about 9 years ago

Change [#662]: Unify alignment to a common base
Doc [#662]: Document how to derive alignment sets for differently sized sprite sets

Revision 424:2835bb1c39b0
Added by planetmaker about 9 years ago

Fix [#662]: Add all those forgotten PCX files
Change [#662]: Move Kirby Paul, UU37 and SH/Hendry 25 to their respective own pcx files and use the alignment template

Revision 424:2835bb1c39b0
Added by planetmaker about 9 years ago

Fix [#662]: Add all those forgotten PCX files
Change [#662]: Move Kirby Paul, UU37 and SH/Hendry 25 to their respective own pcx files and use the alignment template

Revision 426:5f88df5f78b2
Added by planetmaker about 9 years ago

Change [#662]: Chaney Jubilee and GinzuA4 use the 8/8 length pcx and alignment template

Revision 426:5f88df5f78b2
Added by planetmaker about 9 years ago

Change [#662]: Chaney Jubilee and GinzuA4 use the 8/8 length pcx and alignment template

Revision 427:e98b8e421bf7
Added by planetmaker about 9 years ago

Change [#662]: Move Wills2-8-0, Centennial, CS2400, CS4000 and Kelling3100 to their respective own files and use the 8/8 length alignment template for them

Revision 427:e98b8e421bf7
Added by planetmaker about 9 years ago

Change [#662]: Move Wills2-8-0, Centennial, CS2400, CS4000 and Kelling3100 to their respective own files and use the 8/8 length alignment template for them

Revision 428:54d15046449d
Added by planetmaker about 9 years ago

Change [#662]: Move MSJ250, MSJ1000 and TurnerTurbo to their own files and use the 8/8 length alignment template

Revision 428:54d15046449d
Added by planetmaker about 9 years ago

Change [#662]: Move MSJ250, MSJ1000 and TurnerTurbo to their own files and use the 8/8 length alignment template

Revision 429:e0d42ad72f6c
Added by planetmaker about 9 years ago

Fix [#662]: Alignment of temperate maglev and monorail engines and wagons
Change [#662]: Move all monorail and maglev engines to their own pcx file and use them and the 8/8 length alignment template

Revision 429:e0d42ad72f6c
Added by planetmaker about 9 years ago

Fix [#662]: Alignment of temperate maglev and monorail engines and wagons
Change [#662]: Move all monorail and maglev engines to their own pcx file and use them and the 8/8 length alignment template

Revision 430:ae0b8ecc95c0
Added by planetmaker about 9 years ago

Change [#662]: Move the sprites of the tropical CS 2400, CS 4000 and Centennial to their own files and use the 8/8 length alignment template

Revision 430:ae0b8ecc95c0
Added by planetmaker about 9 years ago

Change [#662]: Move the sprites of the tropical CS 2400, CS 4000 and Centennial to their own files and use the 8/8 length alignment template

Revision 431:bc523bdceb38
Added by planetmaker about 9 years ago

Change [#662]: Move sprites of the remaining tropical rail engines to their own files and use the 8/8 length alignment template

Revision 431:bc523bdceb38
Added by planetmaker about 9 years ago

Change [#662]: Move sprites of the remaining tropical rail engines to their own files and use the 8/8 length alignment template

Revision 432:e64a7d611f01
Added by planetmaker about 9 years ago

Cleanup [#662]: Don't define the tropical passenger wagon twice

Revision 432:e64a7d611f01
Added by planetmaker about 9 years ago

Cleanup [#662]: Don't define the tropical passenger wagon twice

Revision 434:63708e6a1e2c
Added by planetmaker about 9 years ago

Change [#662]: Use the 8/8 length template for toyland Mightymover, Ploddyphut diesel and powernaut diesel

Revision 434:63708e6a1e2c
Added by planetmaker about 9 years ago

Change [#662]: Use the 8/8 length template for toyland Mightymover, Ploddyphut diesel and powernaut diesel

Revision 435:db81d2fdcc7c
Added by planetmaker about 9 years ago

Fix [#662]: Alignment of toyland wagons now uses the 7/8 length template
Change [#662]: Move the toyland wagon alignment template to the train template file and use the same definition for temperate

Revision 435:db81d2fdcc7c
Added by planetmaker about 9 years ago

Fix [#662]: Alignment of toyland wagons now uses the 7/8 length template
Change [#662]: Move the toyland wagon alignment template to the train template file and use the same definition for temperate

Revision 436:8b4694a5c11a
Added by planetmaker about 9 years ago

Change [#662]: Move the toyland maglev and monorail engine sprites to their own files and use the 8/8 length alignment template

Revision 436:8b4694a5c11a
Added by planetmaker about 9 years ago

Change [#662]: Move the toyland maglev and monorail engine sprites to their own files and use the 8/8 length alignment template

Revision 437:3c108e8cb638
Added by planetmaker about 9 years ago

Change [#662]: Use the default 8/8 length template also for Ploddyphut and Powernaut Choo Choos

Revision 437:3c108e8cb638
Added by planetmaker about 9 years ago

Change [#662]: Use the default 8/8 length template also for Ploddyphut and Powernaut Choo Choos

History

#1 Updated by planetmaker over 9 years ago

#2 Updated by Ammler over 9 years ago

  • Target version set to 0.3.0

#3 Updated by planetmaker about 9 years ago

  • Subject changed from trains from molace to Rework trains
  • Assignee set to planetmaker

#4 Updated by planetmaker about 9 years ago

#5 Updated by planetmaker about 9 years ago

Interesting thought to be tested very carefully:

Defining Action0 properties for trains which have no game play influence but only visual one:
Property 08 (AI special feature)
Property 1E (Callback 11 = wagon length?, Callback 2D = colour mapping, Callback 33 = Sound effect)
Property 22 (Visual effects)
Property 27, Bits 1 and 2 (2cc and MU)

The wagon length is probably unsafe as it most probably influences the collisional behaviour.

#6 Updated by planetmaker about 9 years ago

In the attached screenshot, I thing that the wagons in the / view are fine but the engine could move a pixel lower and maybe to the right. In the \ view the wagons seem off by one pixel and could move to the upper right, if those vehicles are supposed to be centred aver the tracks

Comments?

#7 Updated by athanasios about 9 years ago

In \ it is very clear that engine is aligned with the rails but the wagons are misaligned.
In / wagons and engine ARE aligned with the rails. I am not sure if the space between engine and wagons needs adjustment.

#8 Updated by planetmaker about 9 years ago

Thanks for the feedback, nice to see confirmed basically what I found, too. This is what it looks like now. I'd appreciate a list of rail sprites or pointers as of which are (most) problematically aligned :-)

#9 Updated by planetmaker about 9 years ago

It's difficult to find a good alignment, especially for basesets (compare the attached screenshots):
- Original alignment is such that it looks ugly as the trains drive in front of the tracks; but depot view is ok
- OpenGFX alignment is such that the trains drive on the tracks - but then the depot view looks ugly

Any ideas what way to go? Or what to modify wrt either of the two alignments?
I guess one solution could be to introduce action 1/2/3 for those trains which would allow to define extra depot sprites - but then that's not something we should do in the extra newgrf which comes with this baseset but can only do in the OpenGFX+ newgrf.

#10 Updated by planetmaker about 9 years ago

Here now also the OpenGFX alignment.

#11 Updated by planetmaker about 9 years ago

  • % Done changed from 10 to 30

Temperate and arctic rail engines and wagons are done.
Maglev and monorail wagons should be fine, too, but that needs testing as those engines have not been re-visited.

Further TODO: tropical and toyland rail engines and wagons and all maglev and monorail engines

#12 Updated by planetmaker about 9 years ago

  • Status changed from Assigned to Feedback
  • % Done changed from 30 to 90

All trains have been revisited. The wagons all have one file per climate, each engine has its own file and uses a modified 2cctrainset alignment template. Documentation on the alignment is found in sprites/nfo/templates/trains.tnfo

Maybe single engines, especially the small steamers need a slight tweaking... maybe some a slight overhaul. See also issues #905 and #906. I attached a test game for each climate to the technical documents section.

Comments welcome :-). The new sprite alignment tool might come in handy.

#13 Updated by planetmaker almost 9 years ago

Check also how engines / alignment looks like, if they are used reversed. This especially needs checking for the shorter vehicles. In particular the Ploddyphut ChoCho and / or Kirby Paul.

#14 Updated by planetmaker over 8 years ago

  • Status changed from Feedback to Resolved
  • % Done changed from 90 to 100

No feedback seems to mean that it's ok now. Closed.

#15 Updated by planetmaker over 8 years ago

  • Status changed from Resolved to Closed

with r498 it should be fine

Also available in: Atom PDF