Bug #605

make bundle in a subdir

Added by Ammler about 10 years ago. Updated over 9 years ago.

Status:ClosedStart date:2009-10-23
Priority:HighDue date:
Assignee:planetmaker% Done:

50%

Category:build system
Target version:-

Description

Installing a bundle seems to be a bit tricky because it doesn't have the content in a directory. This might work for the tar/grf itself, but it fails i.e. for the docs. I highly recommend to put the content in a subdir, I was always in thought this is the case. ;-)

final Edit: seems to be opengfx issue, only. (2cc and firs is fine)

Associated revisions

Revision 229:11e066406791
Added by planetmaker almost 10 years ago

Change [Makefile]: Let bundle_zip uncompress into a subdir instead of the dir the zip file is located in (closes #605)

Revision 229:11e066406791
Added by planetmaker almost 10 years ago

Change [Makefile]: Let bundle_zip uncompress into a subdir instead of the dir the zip file is located in (closes #605)

History

#1 Updated by Ammler about 10 years ago

  • Project changed from NewGRF build framework to OpenGFX

#2 Updated by Ammler about 10 years ago

  • Priority changed from High to Normal

As this is the only GRF writing directly to data/, it isn't that high prio anymore. ;-)

#3 Updated by planetmaker almost 10 years ago

  • Status changed from Confirmed to Closed
  • % Done changed from 0 to 100

Applied in changeset r229.

#4 Updated by Ammler almost 10 years ago

  • Status changed from Closed to Reopened

Please keep the grfs in a tar so it doesn't "waste" open files slots, just like it was but in a subdir, like the other newgrfs...

#5 Updated by Ammler almost 10 years ago

also a quote of someone else ;-)

Why not? We can. It's one easy file and nothing can get lost. And no one is easily tempted to distribute it w/o license file

#6 Updated by planetmaker over 9 years ago

  • Status changed from Reopened to Feedback
  • Assignee set to Ammler

hm, better now? Can it be closed? Or do dirs need renaming?

#7 Updated by Ammler over 9 years ago

make bundle_zip creates a silly name: zip.zip

You still don't tar the grfs in the dir... (not really necessary but was part of that ticket. ;-)

#8 Updated by planetmaker over 9 years ago

  • Category set to build system

#9 Updated by Ammler over 9 years ago

  • Assignee changed from Ammler to planetmaker
  • Priority changed from Normal to High
  • % Done changed from 100 to 50

it still does make a "zip.zip" with make bundle_zip

also consider taring multiple grfs in the bundle...

#10 Updated by Ammler over 9 years ago

[Generating] opengfx-nightly-r362M.zip
        zip warning: name not matched: opengfx-nightly-r362M.zip

This is Zip 2.32 (June 19th 2006), by Info-ZIP.

#11 Updated by Ammler over 9 years ago

  • Status changed from Feedback to Closed

looks fine now, whatever :-)

Also available in: Atom PDF