Bug #4341

Bubble generator sprites incorrect

Added by Alberth almost 7 years ago. Updated almost 7 years ago.

Status:ReopenedStart date:2012-10-06
Priority:LowDue date:
Assignee:-% Done:

80%

Category:-
Target version:-

Description

bubble generator has just 5 sprites, instead of the 10 that you have (right, middle, and left, a tube, and the moving block).

In addition, the right pipe at the NE side does not look connected. See the image for details

In issue #4331, the position of the bubble starting points is discussed.

bubble_gen_result.png (205 KB) Alberth, 2012-10-06 17:04

bubblegen_start2.png (343 KB) Alberth, 2012-10-07 15:30

Associated revisions

Revision 246:f1e03c99d11c
Added by zephyris almost 7 years ago

Fix: Correct number of sprites for bubble generator (Bug #4341).

History

#1 Updated by zephyris almost 7 years ago

The extra sprites are due to lazy use of the render template...
4743 -> 0004
4743 -> 0002
4745 -> 0001
4746 -> 0005
4747 -> 0009

I think that works

#2 Updated by zephyris almost 7 years ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

Applied in changeset f1e03c99d11c.

#3 Updated by Alberth almost 7 years ago

  • Status changed from Closed to Reopened
  • % Done changed from 100 to 60

Great, sprites look quite fine, see the image.
Two issues:

1. The recolour mask does not contain half of the right-most starting point.
2. There is a crack in the pipes (encircled with ugly green) due to the partly pipes in 0001. Since 0002 already has the pipes, maybe just leave the pipes out in 0001 ?

#4 Updated by zephyris almost 7 years ago

  • % Done changed from 60 to 80

I have corrected the mask (r251), correcting the 'crack' in the pipes is a bit harder because of the way the render template is set up. I might save that one till later...

#5 Updated by Alberth almost 7 years ago

bubble generator needs some fine tuning, it seems, the bubbles do not line up exactly with the starting position

#6 Updated by zephyris almost 7 years ago

  • Priority changed from Normal to Low

So close!

Also available in: Atom PDF