Feature #380

TTDPatch support

Added by Ammler almost 10 years ago. Updated over 8 years ago.

Status:ClosedStart date:2009-08-10
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:-
Target version:-

Description

mainly removing OpenTTD only features

TT-Forums thread:
http://www.tt-forums.net/viewtopic.php?t=44560

ttdpatch_bundle.png - Filenames of TTDPatch version from last release (72 KB) Ammler, 2009-08-26 10:07

make.ttdpatch.diff Magnifier (947 Bytes) Ammler, 2010-09-04 03:01

bundle_ttdp.diff Magnifier (1.29 KB) Ammler, 2010-09-04 12:50

Associated revisions

Revision 168:9f04fa209633
Added by Ammler almost 10 years ago

Feature (issue #380): Moved OpenTTD only features to the end and added Action9 to skip it for the patch

Revision 168:9f04fa209633
Added by Ammler almost 10 years ago

Feature (issue #380): Moved OpenTTD only features to the end and added Action9 to skip it for the patch

Revision 547:394bb67c10fd
Added by Ammler over 8 years ago

Feature #380: make target bundle_ttdp

Revision 547:394bb67c10fd
Added by Ammler over 8 years ago

Feature #380: make target bundle_ttdp

History

#1 Updated by Rubidium almost 10 years ago

Don't forget adding the TTDP only (GUI) sprites and suggest calling the extra.grf ttdpbase[w].grf instead.

Secondly, because TTDP needs either DOS or Windows paletted graphics, you probably end up releasing a version for each palette.

#2 Updated by foobar almost 10 years ago

Palette:
OpenGFX uses the Windows palette. TTDPatch users who wish to use OpenGFX can/should use the Windows version of TTDPatch. IMO there's no real need for two versions. At least not during development of OpenGFX that is. Once done we could provide a courtesy DOS versions for the 50 people who want to use that :P

#3 Updated by planetmaker almost 10 years ago

Should we add a new target to the Makefile like "ttdpatch" or so, which will create versions suitable for TTDP?
As Rubidium said, it'll also need creation of a DOS paletted version... though I'm not entirely sure why. Surely it could be done by means of re-applying the palette by means of grfcodec.

#4 Updated by Ammler almost 10 years ago

Well, if we really want to make a special release for TTDP, we should make a newgrf version, so they wouldn't have the hassle with moving files around. One big OpenGFX newgrf which you load in newgrfw.cfg and you are fine.
As you can't run the patch without original data anyway, replacement is obviously useless.

But IMO, the current effort is fine enough, it is at least possible to use OpenGFX in TTDP now.

BTW. 1 (one) download since I posted the renamed opengfx version in the ttdpatch forum. So interests is really very low...

#5 Updated by athanasios almost 10 years ago

Loading as a newgrf is not so desirable. TTDPatch can load a limited amount of sprites (correct me if this has changed-I do not follow TTDPatch development).

We must either use original names or ask Dalestan to support OpenGFX with new code.

#6 Updated by Ammler almost 10 years ago

  • Status changed from New to Feedback

This makes sense, also there isn't really much demand for a patch version. Maybe we could make a Makefile target "bundle_patch", which renames the files and adds a ttdpatch readme. This packs should then be distributed seperately, so we don't confuse the OpenTTD users.

#7 Updated by planetmaker almost 10 years ago

Ammler wrote:

This makes sense, also there isn't really much demand for a patch version. Maybe we could make a Makefile target "bundle_patch", which renames the files and adds a ttdpatch readme. This packs should then be distributed seperately, so we don't confuse the OpenTTD users.

Does it require other modifications than the filenames?

Concerning readme: I wouldn't have a separate one, but a separate TTDP section.

#8 Updated by Ammler almost 10 years ago

planetmaker wrote:

Does it require other modifications than the filenames?

no, just renaming ogfx?_*.grf to trg?r.grf
(no DOS version needed, afaik)

Concerning readme: I wouldn't have a separate one, but a separate TTDP section.

As already mentioned, I would separate the ttdpatch version from our official pack, as it needs its own files, the seperation also means, you "can" use an additional file for less confusion, the ttdpatch readme/section should mention something like that:

Replace your trg?r.grf files with those and include ogfxe_extra.grf to your newgrfw.cfg (Don't forget to backup your original files.)

little info, how the current ttdpatch edition looks:

#9 Updated by Ammler almost 10 years ago

#10 Updated by Ammler over 9 years ago

  • Category set to 28

#11 Updated by Ammler almost 9 years ago

attached patch adds new target to the Makefile to build a bundle for TTDPatch

#12 Updated by Ammler almost 9 years ago

  • Assignee set to planetmaker

#13 Updated by Ammler almost 9 years ago

  • File bundle_ttdp.diff added

new version

#14 Updated by Ammler almost 9 years ago

  • File deleted (bundle_ttdp.diff)

#15 Updated by Ammler almost 9 years ago

#16 Updated by Ammler over 8 years ago

  • Assignee deleted (planetmaker)

There is more needed to make it a generic target for newgrf_makefile framework, like customizing the sed...

Also still missing is DOS palette support.

Still open question is, if and how we shall provide the download from bundles, my proposal is to hide it and linking directly from tt-forums like:
http://bundles.openttdcoop.org/opengfx/nightlies/LATEST/.ttdpatch/

#17 Updated by Ammler over 8 years ago

  • Status changed from Feedback to Closed

since today, also official ttdp releases are available (http://bundles.openttdcoop.org/opengfx/releases/LATEST/ttdpatch/)

Also available in: Atom PDF