Feature #3685

review sparks/smoke

Added by foobar almost 8 years ago. Updated over 7 years ago.

Status:ClosedStart date:2012-02-12
Priority:NormalDue date:
Assignee:-% Done:

100%

Category:-
Target version:2.0.0-beta1

Description

- remove sparks from metro
- mu should only smoke/spark on one vehicle part and not all

Associated revisions

Revision 466:614311f45f50
Added by foobar over 7 years ago

Feature: correct smoke for DMUs (issue #3685)

Revision 467:40bb86a30ce7
Added by foobar over 7 years ago

Feature: correct sparks for Matx EMUs (issue #3685)

Revision 468:e83cb56e16fd
Added by foobar over 7 years ago

Feature: correct sparks for remaining EMUs (closes #3685)

History

#1 Updated by foobar over 7 years ago

  • Target version set to 2.0.0-alpha1

#2 Updated by Purno over 7 years ago

1. Is it possible to let metro spark at the bottom of the vehicle (where it connects to the 3rd rail)?
2. EMUs should spark at every pantograph up, DMUs should smoke at every chimney. If possible?

#3 Updated by foobar over 7 years ago

1: no, sparks can only be repositioned in length, not in height.
2: yes, that's possible, and the intent of this issue ;) I haven't written that down properly in the issue description; for most it will be one, but there are cases where that is not the case.

#4 Updated by Voyager1 over 7 years ago

Regarding the no.2, I've noticed some MUs sparkling all over their length. IIRC one Mat 'something' ELD4 has 1 panto up then 2 down then 1 up but sparks come over all 4 of them.

#5 Updated by foobar over 7 years ago

Good observation, that is indeed how it's programmed now :P

#6 Updated by Purno over 7 years ago

foobar wrote:

1: no, sparks can only be repositioned in length, not in height.

And I guess it's not possible to define new sprites for metro sparkling either? :>

#7 Updated by foobar over 7 years ago

No. There's just one set of sparks that is used by all vehicles that need to have sparks.

#8 Updated by foobar over 7 years ago

  • Target version changed from 2.0.0-alpha1 to 2.0.0-beta1

#9 Updated by foobar over 7 years ago

  • Priority changed from Low to Normal

#10 Updated by foobar over 7 years ago

correct smoke for steamers is in r455, but I linked the wrong issue from the commit

#11 Updated by foobar over 7 years ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

Applied in changeset e83cb56e16fd.

Also available in: Atom PDF