Code Review #3559

Predefined constants for common refit masks

Added by planetmaker almost 8 years ago. Updated about 3 years ago.

Status:ClosedStart date:2012-01-19
Priority:LowDue date:
Assignee:-% Done:

100%

Category:-
Target version:-

Description

It might not have gotten properly updated when adding the two new cargo classes. Is it sensible at all?

Associated revisions

Revision 1811:9416f606536d
Added by Hirundo almost 8 years ago

Fix: #3559: ALL_[NORMAL_]CARGO_CLASSES did not quite represent all cargo classes any more.

Revision 1811:9416f606536d
Added by Hirundo almost 8 years ago

Fix: #3559: ALL_[NORMAL_]CARGO_CLASSES did not quite represent all cargo classes any more.

History

#1 Updated by yexo almost 8 years ago

It can be useful if you want to make a vehicle refitable to all cargo classes except one. For example: ALL_NORMAL_CARGO_CLASSES & ~bitmask(CC_PASSENGERS). However I doubt this is a normal usecase.

#2 Updated by Hirundo almost 8 years ago

NFO documentation contains some useful info on usage of cargo classes, this should be referenced in / copied to the NML documentaion

ALL_NORMAL_CARGO_CLASSES might not be really useful indeed, but I don't know if there are any projects that depend on it.

#3 Updated by planetmaker almost 8 years ago

We could indeed offer some other prefab bitmasks, in accordance with the suggestsions found in the NFO table. That'll need careful working out, though.

#4 Updated by Hirundo almost 8 years ago

Having predefined constants for e.g. bulk, piece goods, flatbeds, tankers and refrigerated vans would be nice. I'm not sure though, if we can find something that makes sense without requiring the explicit include/exclude lists. ogfx-trains/rvs currently cannot, it seems.

#5 Updated by Hirundo almost 8 years ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

Applied in changeset 9416f606536d.

#6 Updated by Hirundo almost 8 years ago

  • Subject changed from ALL_NORMAL_CARGO_CLASSES to Predefined constants for common refit masks
  • Status changed from Closed to Feedback
  • Priority changed from Normal to Low
  • % Done changed from 100 to 0

#7 Updated by Hirundo about 7 years ago

  • Status changed from Feedback to Closed
  • % Done changed from 0 to 100

Applied in changeset 9416f606536d.

#8 Updated by Ammler about 7 years ago

  • Status changed from Closed to Reopened
  • % Done changed from 100 to 0

(migration issue)

#9 Updated by Hirundo over 6 years ago

  • Status changed from Reopened to Closed
  • % Done changed from 0 to 100

Applied in changeset eddi-nml:9416f606536d.

#10 Updated by planetmaker over 6 years ago

  • Status changed from Closed to Reopened

#11 Updated by planetmaker over 6 years ago

  • % Done changed from 100 to 50

#12 Updated by Hirundo about 3 years ago

  • % Done changed from 50 to 100
  • Status changed from Reopened to Closed

Applied in changeset 9416f606536d.

Also available in: Atom PDF