Code Review #3403

Vehicle names

Added by Eddi almost 8 years ago. Updated over 7 years ago.

Status:ClosedStart date:2011-12-25
Priority:NormalDue date:
Assignee:-% Done:

90%

Category:-
Target version:-

Description

We need to decide on a uniform vehicle naming scheme, and some issues about which parts should be translatable.

History

#1 Updated by Eddi almost 8 years ago

there's some (apparently older, but uncommited) changes in the tracking table adding lots of spaces to vehicle names, e.g. "S4" => "S 4".

i kinda liked it more without the spaces.

#2 Updated by Eddi almost 8 years ago

"VT 137" makes a bad choice for naming vehicles, as it's not one series, but basically "all diesel railcars with 4 axles", we should take alternative names in those cases (like the later DB scheme) instead of having lots of "VT 137 XXX" vehicles.

#3 Updated by michi_cc almost 8 years ago

Eddi wrote:

there's some (apparently older, but uncommited) changes in the tracking table adding lots of spaces to vehicle names, e.g. "S4" => "S 4".

The variant with space seems to be the historically correct one, but historical accuracy isn't the only important thing of course.

#4 Updated by Eddi almost 8 years ago

if you aim for historic accuracy you also need to consider the numbering with superscript (e.g. G7²) vs. the more computer-friendly numbering with . (e.g. G7.2)

#5 Updated by michi_cc almost 8 years ago

The TTD base set contains ¹²³ (even if a bit small for good reading) as far as I can see, and glyphs for other numbers could be added if necessary.

#6 Updated by oberhuemer almost 8 years ago

I see that as too much trouble, since it seems there's only a string code for a -1 superscript (reference: http://newgrf-specs.tt-wiki.net/wiki/StringCodes). Of course, "some other person" may be interested anyway.
Translating vehicle (at least engine) names: I support choosing them so they won't be anything to translate. That would mean only using the class number and an abbreviation for the company.

#7 Updated by Eddi almost 8 years ago

Translation is needed for the wagons

#8 Updated by Eddi almost 8 years ago

oberhuemer wrote:

I see that as too much trouble, since it seems there's only a string code for a -1 superscript (reference: http://newgrf-specs.tt-wiki.net/wiki/StringCodes).

as far as i see, these only apply for non-unicode strings. since we use unicode, there is no need for such "string codes"

#9 Updated by Eddi almost 8 years ago

i replaced the ¹²³ glyphs to something slightly more readable, and introduced glyphs for the other digits (0-9), and the roman numerals I and V.

also, you can now enter these glyphs with {SUP:XXX} in the tracking table.

For example the "BR 99.750" can now be written with "BR 99{SUP:750}" and the "BR EP 3/6II" can now be written with "BR EP 3/6{SUP:II}"

#10 Updated by Eddi almost 8 years ago

ok seriously, "EP 4 x 1/1" is a little bit too much with the spaces...

#11 Updated by oberhuemer almost 8 years ago

...but undeniably correct.

So, what about changing the names now? To continue with that example, "Baureihe EG 4 x 1/1 (bay., BR EG 1, BR E 73.0)" would turn into "K. Bay. Sts. B. EG 4 x 1/1 (EG 1, DRG E 73.0)".

#12 Updated by oberhuemer almost 8 years ago

Done it, though there are many missing the "DRG" especially still.

#13 Updated by oberhuemer almost 8 years ago

  • % Done changed from 0 to 50

#14 Updated by oberhuemer over 7 years ago

  • Status changed from New to Closed
  • % Done changed from 50 to 90

Not really anything more to say

Also available in: Atom PDF