Bug #2914

Handling of Dxxx strings

Added by Hirundo over 8 years ago. Updated about 8 years ago.

Status:ClosedStart date:2011-07-31
Priority:NormalDue date:
Assignee:-% Done:

100%

Category:-
Target version:-

Description

When using nforenum on an NML-encoded grf, two errors related to Dxxx strings appear:
- Error, because strings are referenced before they are defined.
- Linter failure, because the feature of the action 4 is wrong (according to nforenum). NML outputs all Dxxx action4s with feature 08 (general), which is fine for ottd but invalid according to specs.

Whether this needs fixing, and how, needs looking into.

Associated revisions

Revision 1642:786ac8bbab38
Added by yexo about 8 years ago

Fix (partly) #2914: define strings before they are used (=directly after action8 instead of at the end of the file)

Revision 1642:786ac8bbab38
Added by yexo about 8 years ago

Fix (partly) #2914: define strings before they are used (=directly after action8 instead of at the end of the file)

Revision 1643:45bc1732c505
Added by yexo about 8 years ago

Fix #2914: set the feature byte in action4 correctly for Dxxx strings

Revision 1643:45bc1732c505
Added by yexo about 8 years ago

Fix #2914: set the feature byte in action4 correctly for Dxxx strings

History

#1 Updated by yexo about 8 years ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

Applied in changeset 45bc1732c505.

Also available in: Atom PDF