Code Review #2884

passenger wagons

Added by Eddi almost 9 years ago. Updated over 7 years ago.

Status:AssignedStart date:2011-07-21
Priority:NormalDue date:
Assignee:-% Done:

80%

Category:-
Target version:-

Description

At this stage, it's probably way too early to decide any of this, but i think it's better to share my thoughts so we have a basis for discussion.

Preliminaries:
"Real" railways have several different train classes. The DBSetXL offers two, but maybe we want to offer more.

Passenger wagons should not grow in capacity over time, only in speed.

So that leaves us with three values to balance:
  • capacity per tile (independent from the actual length of the vehicles)
  • max speed
  • costs (buy/running)
Capacity scheme:
I would distinguish three types here: express (low capacity), passenger (medium capacity) and commuter (high capacity)
e.g:
  • express: 60-80 per tile
  • passenger: 100-120 per tile
  • commuter: 120-150 per tile
Speed scheme:
I would distinguish four types here: express (only limited by engine speed), accelerated passenger (relatively fast), passenger (slower), commuter (very slow)
e.g.: (express, accelerated, passenger, commuter)
  • ca. 1910: 120km/h, 100km/h, 70km/h, 50km/h
  • ca. 1935: 150km/h, 120km/h, 90km/h, 80km/h
  • ca. 1995: 280km/h, 160km/h, 120km/h, 100km/h
Price scheme:
I would distinguish two types here: express (expensive), passenger (cheap)
e.g.
  • express: has high running cost (includes accelerated passenger)
  • passenger: has no (or low) running cost (includes commuter)

these three categories are not independent, so you do not get exponential growth. this would result in four different wagon types available at each period, maybe some through refitting.

(Note: some of these things might be omitted in the "Core" set and only available in the "Extended" set)

History

#1 Updated by Eddi almost 9 years ago

  • Description updated (diff)

#2 Updated by Eddi almost 9 years ago

  • Description updated (diff)

#3 Updated by michi_cc almost 9 years ago

It probably makes sense to look at NewGRF-definable, per vehicle custom cargo decay for that as well. I'm going to take a look at the code for that.

#4 Updated by Eddi almost 9 years ago

Example for 1935:
  • D-Zug with BR E18 and long distance wagons runs 150km/h
  • Eilzug with BR E04 and passenger wagons (refit for express usage) goes 120km/h (with long distance wagons it could go 130, but has lower capacity)
  • Personenzug with BR E44 and passenger wagons runs 90km/h

#5 Updated by Eddi almost 9 years ago

if we get custom cargo decay, we can have for example:
  • commuter car: fast decay
  • passenger car: medium decay
  • express car: lower decay
  • luxury/sleeping car: very low decay (e.g. "Rheingold")
  • dining car: no capacity, but affects decay for all wagons in the train

but i think these last two should go into the extended set only.

for reference, the old cargo decay discussion is here: http://www.tt-forums.net/viewtopic.php?f=68&t=54450

#7 Updated by oberhuemer almost 9 years ago

michi_cc wrote:

http://vcs.openttd.org/git/?p=openttd/trunk.git;a=commit;h=d25840978c714b0dac6699883b35af22cb76801e

Thanks a lot :)

This concept seems good to me, by the way.

#8 Updated by oberhuemer over 8 years ago

  • % Done changed from 0 to 80

More or less finished. Wagon running costs still could use some finer adjustments (repurpose the steam engine running cost base?)

#9 Updated by oberhuemer over 7 years ago

  • Tracker changed from Feature to Code Review
  • Status changed from New to Assigned

Also available in: Atom PDF