Bug #2261

build with new(est) version of NML

Added by planetmaker almost 9 years ago. Updated almost 9 years ago.

Status:RejectedStart date:2011-02-07
Priority:NormalDue date:
Assignee:planetmaker% Done:

0%

Category:-
Target version:-

Description

OpenGFX+ Trains 0.2.2 was built with NML r1166 while at the same time already r1179 was the current version.

Besides this point and more for the makefile framework: is it a good idea to ship information on the required NML version with a build of an NML NewGRF?

History

#1 Updated by Ammler almost 9 years ago

not tested but should already be possible

nml needs to trigger build on push as r1166 is right now the newest version

r1166    2011-02-05    nml    nightlies    d8e9173e004a

and you should fail the build, if the nml version is too old.

#2 Updated by planetmaker almost 9 years ago

Well, the issue I had was: both versions built the newgrf - but the resulting md5sum is different. Which sucks for a release build; and it actually took me some time to find that the DevZone use not nml tip but rather an older, probably the nightly version.

#3 Updated by Ammler almost 9 years ago

yes, as said, if you need newer releases as nightlies, add nml builds on push or tag nml

if you do that, you also need to change the require of the nml projects, they use nightlies per default

note: the used package version is noted in at least 2 files:

#4 Updated by Ammler almost 9 years ago

  • Assignee set to planetmaker

shall I configure this for you, else please close.

#5 Updated by planetmaker almost 9 years ago

  • Status changed from New to Rejected

Nightly is fine enough.

Also available in: Atom PDF