Bug #1273

true grfID and reported grfID in documentation differ

Added by planetmaker about 9 years ago. Updated over 8 years ago.

Status:ConfirmedStart date:2010-07-04
Priority:NormalDue date:
Assignee:planetmaker% Done:

0%

Category:-
Target version:-

Description

useless
[14:00] <Yexo> planetmaker: ser readme says the grfid is "SER" 00 but the code uses "SER0" (difference is literal 0 byte vs '0' (byte value 48 = 0x30)
[14:00] <Yexo> fo really make it "SER" 00 you should use "SER
[14:00] * andythenorth would like to get to FIRS 1.0 one day
[14:00] <Yexo> "SER\00" in the code
[14:01] <planetmaker> very good point Yexo. I'll need to fix the readme, using the same thing as the code :-)
[14:01] <planetmaker> I guess it needs some more pre-processing power :-)
[14:02] <planetmaker> problem is that it's defined twice... it shouldn't... hm

It's defined in both header.pnml and in Makefile.config. Maybe one should write a defines.pnml which is written by the Makefile framework and included as the first pnml file in the main pnml file. As such it then can define what is being used as GRFID.

History

#1 Updated by planetmaker almost 9 years ago

  • Category set to NML

#2 Updated by planetmaker over 8 years ago

also the handling of it without the quotation marks would be nice

#3 Updated by planetmaker over 8 years ago

  • Category deleted (NML)
  • % Done changed from 100 to 0

Also available in: Atom PDF