Code Review #1086

which is not installed on CentOS or RHEL

Added by Ammler over 9 years ago. Updated over 9 years ago.

Status:ClosedStart date:2010-07-08
Priority:NormalDue date:
Assignee:planetmaker% Done:

100%

Category:-
Target version:0.4.0

Description

I suggest a little change:

[ `which nforenum 2>/dev/null` ] && echo "nforenum" || [ `ls /usr/bin/nforenum 2>/dev/null` ] && echo "nforenum" || echo "renum"

fix_detect_nforenum_name.p1.diff Magnifier (499 Bytes) Ammler, 2010-07-09 13:46

Associated revisions

Revision 128:42767f74ab26
Added by planetmaker over 9 years ago

Change: renum is now officially called nforenum everywhere (closes #1086)

History

#1 Updated by Ammler over 9 years ago

patch tested with opengfx:
https://build.opensuse.org/package/show?package=opengfx&project=home%3Aopenttdcoop

if you don't like it, we should at least apply it to the opengfx repo...

#2 Updated by Ammler over 9 years ago

Other alternative would be to which for renum and use nforenum as default

#3 Updated by Rubidium over 9 years ago

I'd change the default after the next nforenum (i.e. when the default binaries becomes nforenum)

#4 Updated by planetmaker over 9 years ago

  • Target version set to 0.4.0

The default should be changed to nforenum once there's an official new version of it. Then this decision-making can basically be dropped.

#5 Updated by Ammler over 9 years ago

the official release is here, renum is gone, so this could be changed...

#6 Updated by planetmaker over 9 years ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

Applied in changeset 42767f74ab26.

Also available in: Atom PDF