Bug #7540

Packaging misses nml module directory

Added by planetmaker about 2 years ago. Updated almost 2 years ago.

Status:ClosedStart date:2015-03-04
Priority:NormalDue date:
Assignee:-% Done:

100%

Category:-
Target version:0.4.1

Description

»» 19:44:53 < heffer> planetmaker: fixed nml 0.4.0 source tarball in sight? :D
»» 19:45:14 <@planetmaker> ehm, would be 0.4.1 :)
»» 19:45:23 < heffer> okay :D
»» 19:48:21 <@planetmaker> heffer: can you check whether the current dev version is more to your liking? :) http://bundles.openttdcoop.org/nml/push/LATEST/ The manifest was really borked
»» 19:49:33 <@planetmaker> it doesn't fix the un-nice version in the filename though. Just that it should build at all ;)
»» 19:52:42 < Eddi|zuHause> call it 0.4.0.1 in memory of openttd's version scheme :p
»» 19:55:09 <@planetmaker> :P
»» 20:01:28 < heffer> planetmaker: looks good. seems to build without an error :D
»» 20:02:15 !- Celestar1 [~Celestar@pD9FE9207.dip0.t-ipconnect.de] has joined #openttd
»» 20:04:51 < heffer> hmm nmlc gives me "ImportError: No module named 'nml'"
»» 20:05:17 <@planetmaker> hm
»» 20:06:46 < heffer> i do python3 setup.py build first
»» 20:07:11 < heffer> then python3 setup.py install -O1 --skip-build --root $RPM_BUILD_ROOT
»» 20:07:33 < heffer> and it doesn't seem to install all files to the correct directory
»» 20:09:34 < heffer> yup. looks like the whole nml module directory is not installed: http://paste.fedoraproject.org/191777/51505451/
»» 20:13:59 -!
alluke [~] has joined #openttd
»» 20:14:13 < alluke> ffffffuuuuuuuucking fuck
»» 20:14:17 < alluke> angerfist in helsinki today
»» 20:14:24 < alluke> but sold out >:(
»» 20:19:12 <@Terkhen> ...
»» 20:19:21 < V453000> hi Terkhen :)
»» 20:19:24 <@Terkhen> hi V453000
»» 20:21:01 <@planetmaker> o/
»» 20:24:12 <@planetmaker> hm, so setup.py install fails, heffer?
»» 20:24:53 <@planetmaker> hm...
»» 20:24:59 <@planetmaker> sucks
»» 20:25:12 <@planetmaker> do you want to write me a patch? :D
»» 20:32:26 !- FLHerne [~] has joined #openttd
»» 20:38:17 -!
oskari89 [] has joined #openttd
»» 20:38:38 < alluke> o/
»» 20:39:37 < heffer> planetmaker: i'm afraid i won't be able to. I'm currently moving :D

fix_packaging.diff Magnifier (623 Bytes) oberhuemer, 2015-03-22 18:41

version_pep440.diff Magnifier (2.24 KB) planetmaker, 2015-04-10 14:00

Associated revisions

Revision 2281:4cc36720aa9a
Added by planetmaker almost 2 years ago

Change #7540: Try to improve packaging by applying some in-built automatisms via find_package() (oberhumer)

History

#1 Updated by planetmaker about 2 years ago

I suspect without good foundation and time to test that setup.py misses a line which reads similar to
package = ['nml']

#2 Updated by oberhuemer about 2 years ago

Here's a two-liner fix (closes #7221 as well, which is the same problem).

#3 Updated by frosch almost 2 years ago

< FLHerne> /usr/lib/python3.4/site-packages/setuptools/dist.py:291: UserWarning: The version specified ('0.4.0.r5564M:b4b82c1379a2') is an invalid version, this may not work as expected with newer versions of setuptools, pip, and PyPI. Please see PEP 440 for more details.

#4 Updated by planetmaker almost 2 years ago

PEP440 requires to somewhat restructure version output. Attached a suggestion.
However it doesn't quite use the post-release thing as it should be... but it spares us to update the next version info (which was forgotten also to update after the last release)

https://www.python.org/dev/peps/pep-0440/

#5 Updated by frosch almost 2 years ago

  • % Done changed from 0 to 100
  • Status changed from New to Closed

Also available in: Atom PDF