Bug #3785
Missing parts of large sprites
| Status: | Closed | Start date: | 2012-03-06 | |
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assignee: | - | % Done: | 100% |
|
| Category: | - | |||
| Target version: | - |
Description
nmlc r1872 (self-compiled, unmodified, Windows)
OpenTTD r24016
Parts of 'large' sprites are missing when compiled with nmlc. Seems similar to the issue fixed by r1662.
Test case: all preview sprites in OpenGFX+Airports have this issue, except for the heliport and helidepot. The input sprites are ok, but ingame some areas are missing.
Associated revisions
Fix #3785: Fix tile compression to remove some useless (for grfv2) code and add a missing check for the chunk length.
Fix #3785: Fix tile compression to remove some useless (for grfv2) code and add a missing check for the chunk length.
History
#1 Updated by planetmaker over 1 year ago
- Status changed from New to Confirmed
That looks strange indeed.
#2 Updated by Hirundo over 1 year ago
- File fix_tile_compr.diff
added
Disabling tile compression (in NML source) causes the bug to disappear, so the issue must be somewhere in there.
Attached is a diff that seems to fix the issue at hand. Yexo, could you take a look at it?
#3 Updated by yexo over 1 year ago
- File 3785.diff
added
I think this is better, not sure if your version might cause trouble with wide sprites.
#4 Updated by Hirundo over 1 year ago
- Status changed from Confirmed to Closed
- % Done changed from 0 to 100
Applied in changeset a4e73cfd1c76.