Bug #3439

build does not work with -j > 1

Added by Ammler about 6 years ago. Updated almost 2 years ago.

Status:ClosedStart date:2011-12-31
Priority:NormalDue date:
Assignee:-% Done:

100%

Category:build system
Target version:0.5.0

Description

after discussion it seems to be mainly a issue of gimp, following patch forces makefile to -j1:

diff -r 4bc37de07e5e scripts/Makefile.common
--- a/scripts/Makefile.common    Fri Dec 30 14:15:21 2011 +0100
+++ b/scripts/Makefile.common    Sat Dec 31 15:10:38 2011 +0100
@@ -16,6 +16,7 @@
 # Don't delete intermediate files
 .PRECIOUS: %.nml %.scm %.gimp.png
 .SECONDARY: %.nml %.scm %.gimp.png
+.NOTPARALLEL:

 ################################################################
 # Cleaning targets

maybe it could be guarded and overruled by a parameter like --QUICK or so, and only be used if gimp is installed/used

parallel-gimp.patch Magnifier (1.87 KB) planetmaker, 2012-04-14 12:14

Associated revisions

Revision 900:40d5d95cb783
Added by Ammler about 6 years ago

Fix [#3439]: force makefile to build with one thread only

Revision 900:40d5d95cb783
Added by Ammler about 6 years ago

Fix [#3439]: force makefile to build with one thread only

Revision 901:b8a61eab0058
Added by Ammler about 6 years ago

Fix #3439 (r748): maintainer still needs the check file and special makefile config

Revision 901:b8a61eab0058
Added by Ammler about 6 years ago

Fix #3439 (r748): maintainer still needs the check file and special makefile config

History

#1 Updated by Ammler about 6 years ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

Applied in changeset b8a61eab0058.

#2 Updated by Ammler about 6 years ago

  • Status changed from Closed to Reopened

should be guarded so it can be overruled...

#3 Updated by Ammler about 6 years ago

also needs merge to default

#4 Updated by planetmaker about 6 years ago

  • Target version set to 0.5.0

#5 Updated by planetmaker almost 6 years ago

  • Category set to build system

#6 Updated by Ammler almost 6 years ago

  • Status changed from Reopened to Closed

Applied in changeset b8a61eab0058.

#7 Updated by Ammler almost 6 years ago

  • Status changed from Closed to Reopened

closed again during refetch for parents

#8 Updated by planetmaker almost 6 years ago

There's a patch from blathijs which works on linux. It fails on OSX as the app bundle sets the variable in the script acting as gimp binary

#9 Updated by Ammler almost 2 years ago

  • Status changed from Reopened to Closed

Applied in changeset opengfx-dev:opengfx-dev|commit:b8a61eab0058.

Also available in: Atom PDF