Bug #2339

Processing of Station Action0 Property 09

Added by Lakie over 3 years ago. Updated over 3 years ago.

Status:RejectedStart date:2011-02-18
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:-
Target version:-

Description

It appears that grfcodec and nforenum rejects escape sequences in station action0 property 09, nforenum commenting out the lines, and grfcodec refusing to continue processing.

Both accept this:

09
  01
    F4 03 00 00
      00 00 00   10 04 10   2D 84 00 00
        00 00 80   00 00 00   2E 44 22 03
      00 0C 00   10 04 10   35 84 00 00
        00 00 80   00 00 00   36 44 22 03
      80

But not this, though seemingly the same:

09
  \b1
    \d1012
      00 00 00   10 04 10   \dx842d
        00 00 80   00 00 00   \dx322442e
      00 0C 00   10 04 10   \dx8435
        00 00 80   00 00 00   \dx3224436
      80

I don't see any particular reason why it shouldn't accept either, and since Action2Layouts supports the use of escape sequences, its inconsistent behavior?

Associated revisions

Revision 830:3f4c1e563aaa
Added by frosch over 3 years ago

Fix #2339 -ish: Disable warning 209 when checking action 0 raw ('l') data.

History

#1 Updated by Lakie over 3 years ago

  • Subject changed from nforenum : station Actio0 property 09 to Processing of Station Action0 Property 09

#2 Updated by Lakie over 3 years ago

  • Status changed from New to Rejected

Turns out the nfo exhibiting the issues was using a vastly old version (5) causing any escape sequences to die horribly. That said it, does give warning 209 for the ground sprite with version 7, which is incorrect?

//!!Warning (209): Offset 12: Found byte 1 of a 4-byte escape while reading byte 1 of a 1-byte field.
    9 * 697     00 04 05 01 00
        08 "DFLT" 
        09
          \b8
            \d1012
              00 00 00   10 04 10   \dx842d
                00 00 80   00 00 00   \dx322442e
              00 0C 00   10 04 10   \dx8435
                00 00 80   00 00 00   \dx3224436
              80
...

Also available in: Atom PDF